Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLF4J Logger rewrite part2 #492

Merged
merged 11 commits into from
Nov 13, 2017
Merged

SLF4J Logger rewrite part2 #492

merged 11 commits into from
Nov 13, 2017

Commits on Sep 28, 2017

  1. Started with SLF4J stage 2. Added SLF4J Logger (fallback) and Factory

    @kantenkugel
    kantenkugel committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    9ee270e View commit details
    Browse the repository at this point in the history

  2. Moved SimpleLogger to jda pkg, made it package private, removed jdocs

    @kantenkugel
    kantenkugel committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    78d0fa7 View commit details
    Browse the repository at this point in the history

  3. Added SLF4J to the README

    @kantenkugel
    kantenkugel committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    eb9b830 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. First iteration of replacing string concats of loggers with lazy para… 

    …meters
    @kantenkugel
    kantenkugel committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    71aba77 View commit details
    Browse the repository at this point in the history

  2. Added docs, fixed formatting, added lazy string construction

    @kantenkugel
    kantenkugel committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    6feb979 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2017

  1. Further improved docs in JDALogger and added priv constructor

    @kantenkugel
    kantenkugel committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    30174cf View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Improved log messages for exceptions in AudioConnection and collapsed… 

    … some logs into a single log statement
    @kantenkugel
    kantenkugel committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    022187b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2017

  1. merged in current master and fixed conflicts/SimpleLog calls

    @kantenkugel
    kantenkugel committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    2aa3663 View commit details
    Browse the repository at this point in the history

  2. Fixed some logger calls to properly use "{}"

    @kantenkugel
    kantenkugel committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    7fb842c View commit details
    Browse the repository at this point in the history

  3. Added try/catch in onTextMessage to print full JSON package when an e… 

    …rror occurs outside of handling

Applied review suggestions
    @MinnDevelopment
    MinnDevelopment committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    fc92163 View commit details
    Browse the repository at this point in the history

  4. Added handling for CHANNEL_UPDATE for a not existing category

    @MinnDevelopment
    MinnDevelopment committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    bbb0ba2 View commit details
    Browse the repository at this point in the history