Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paginator can now not use an embed #76

Merged
merged 7 commits into from
Dec 15, 2021

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Sep 24, 2021

The paginator now will not always use an embed. This allows non-embedded pagination since embeds are restricted to a maximum width which we cannot control, but codeblocks are restrained to the width of the screen.

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #76 (c9b33a3) into main (4b07917) will decrease coverage by 1.55%.
The diff coverage is 10.81%.

❗ Current head c9b33a3 differs from pull request most recent head 81b5692. Consider uploading reports for the commit 81b5692 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   70.90%   69.34%   -1.56%     
==========================================
  Files          33       33              
  Lines        1619     1628       +9     
  Branches      199      207       +8     
==========================================
- Hits         1148     1129      -19     
- Misses        439      462      +23     
- Partials       32       37       +5     
Impacted Files Coverage Δ
tests/modmail/utils/test_pagination.py 100.00% <ø> (ø)
modmail/utils/pagination.py 33.96% <10.81%> (-9.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7347f59...81b5692. Read the comment docs.

@onerandomusername onerandomusername added a: bot Catch all for issues regarding the bot p: normal Normal Priority s: needs review Ready for review and merge t: enhancement Changes or improvements to existing features labels Oct 4, 2021
@onerandomusername onerandomusername added the skip changelog Skip the need for a changelog entry for a Pull Request label Oct 4, 2021
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Outdated Show resolved Hide resolved
@discord-modmail discord-modmail deleted a comment from coveralls Dec 2, 2021
Copy link
Member

@Shivansh-007 Shivansh-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested

@onerandomusername
Copy link
Member Author

Will rebase.

modmail/utils/pagination.py Outdated Show resolved Hide resolved
modmail/utils/pagination.py Show resolved Hide resolved
@onerandomusername onerandomusername merged commit d47e097 into main Dec 15, 2021
@onerandomusername onerandomusername deleted the fix/paginator-options branch December 15, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: bot Catch all for issues regarding the bot p: normal Normal Priority s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request t: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants