-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/error handler #77
Conversation
onerandomusername
commented
Sep 25, 2021
- feat: add initial error handler
- add some CheckFailure handling support
- fix: implement remaining UserInputErrors
- fix: title regex
- fix: add concurrency errors and cooldown error support
- fix: don't log CommandNotFound errors unless in a dev mode
- fix: handle bot missing permissions
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 38.62% 33.29% -5.33%
==========================================
Files 16 17 +1
Lines 769 892 +123
Branches 105 132 +27
==========================================
Hits 297 297
- Misses 459 582 +123
Partials 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good, although I can't test at the moment because I'm not on my usual dev environment. One side question: should "dm" or "dming" be capitalized?
There is a fundamental issue with the botmissingpermissions error handling. In almost all send message cases, the bot will make a second case which will 100% fail. The bot should check its cache or request the channel perms to see if it has send message perms. If it does, should also check for embed image permissions, and send a standard message of content if that fails. if that is not a valid permission, the bot should see if it has add_reaction permissions and maybe add a |
45ee4d3
to
34e7696
Compare
This is implemented in 7f19996 |
3285dd0
to
144b008
Compare