Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: embedify all of the meta commands #78

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Sep 27, 2021

Old responses:
image

New responses:
image

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #78 (538d9fe) into main (34c44db) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   33.29%   33.25%   -0.04%     
==========================================
  Files          17       17              
  Lines         892      893       +1     
  Branches      132      132              
==========================================
  Hits          297      297              
- Misses        582      583       +1     
  Partials       13       13              
Impacted Files Coverage Δ
modmail/extensions/meta.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34c44db...538d9fe. Read the comment docs.

@onerandomusername onerandomusername added a: bot Catch all for issues regarding the bot p: normal Normal Priority s: needs review Ready for review and merge t: enhancement Changes or improvements to existing features labels Sep 27, 2021
Copy link
Member

@Shivansh-007 Shivansh-007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@onerandomusername
Copy link
Member Author

This pr should wait until GH-75 is merged as it will cause merge conflicts, and I would rather resolve them here than on that pr.

@onerandomusername
Copy link
Member Author

Actually, the conflicts are easy enough to fix there, so I'll merge this now.

@onerandomusername onerandomusername merged commit b96f63a into main Oct 4, 2021
@onerandomusername onerandomusername deleted the enhance-meta-commands branch October 4, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: bot Catch all for issues regarding the bot p: normal Normal Priority s: needs review Ready for review and merge t: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants