Fix CalculateScore throwing on missing parameters (#727)

* Fix CalculateScore throwing on missing parameters * Bump to version 1.0.1
discord-net · Jul 5, 2017 · 7597cf5 · 7597cf5
1 parent c316b29
commit 7597cf5
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Discord.Net.Commands/CommandService.cs b/src/Discord.Net.Commands/CommandService.cs
@@ -309,8 +309,11 @@ float CalculateScore(CommandMatch match, ParseResult parseResult)
 
                 if (match.Command.Parameters.Count > 0)
                 {
-                    argValuesScore = parseResult.ArgValues.Sum(x => x.Values.OrderByDescending(y => y.Score).FirstOrDefault().Score) / match.Command.Parameters.Count;
-                    paramValuesScore = parseResult.ParamValues.Sum(x => x.Values.OrderByDescending(y => y.Score).FirstOrDefault().Score) / match.Command.Parameters.Count;
+                    var argValuesSum = parseResult.ArgValues?.Sum(x => x.Values.OrderByDescending(y => y.Score).FirstOrDefault().Score) ?? 0;
+                    var paramValuesSum = parseResult.ParamValues?.Sum(x => x.Values.OrderByDescending(y => y.Score).FirstOrDefault().Score) ?? 0;
+
+                    argValuesScore = argValuesSum / match.Command.Parameters.Count;
+                    paramValuesScore = paramValuesSum / match.Command.Parameters.Count;
                 }
 
                 var totalArgsScore = (argValuesScore + paramValuesScore) / 2;