Skip to content

Commit

Permalink
Fix Slash Command Localizations lost after AddCommandsToGuildAsync an…
Browse files Browse the repository at this point in the history
…d deleteMissing = false (#2758)

fetch localizations when adding commands with `deleteMissing` = `false`

fixes #2757
  • Loading branch information
MaxEtMoritz committed Nov 18, 2023
1 parent ab3b30d commit 8d5022a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/Discord.Net.Interactions/InteractionService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ public async Task<IReadOnlyCollection<RestGuildCommand>> RegisterCommandsToGuild
if (!deleteMissing)
{

var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false);
var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand All @@ -416,7 +416,7 @@ public async Task<IReadOnlyCollection<RestGlobalCommand>> RegisterCommandsGlobal

if (!deleteMissing)
{
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false);
var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand Down Expand Up @@ -481,7 +481,7 @@ public async Task<IReadOnlyCollection<RestGuildCommand>> AddCommandsToGuildAsync

if (!deleteMissing)
{
var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false);
var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand Down Expand Up @@ -523,7 +523,7 @@ public async Task<IReadOnlyCollection<RestGuildCommand>> AddModulesToGuildAsync(

if (!deleteMissing)
{
var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false);
var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand All @@ -547,7 +547,7 @@ public async Task<IReadOnlyCollection<RestGlobalCommand>> AddModulesGloballyAsyn

if (!deleteMissing)
{
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false);
var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand Down Expand Up @@ -590,7 +590,7 @@ public async Task<IReadOnlyCollection<RestGlobalCommand>> AddCommandsGloballyAsy

if (!deleteMissing)
{
var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false);
var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false);
var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name));
props.AddRange(missing.Select(x => x.ToApplicationCommandProps()));
}
Expand Down

0 comments on commit 8d5022a

Please sign in to comment.