Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IUserMessage#GetReactionUsersAsync() should take an IEmote instead of a string. #730

Closed
AntiTcb opened this issue Jun 30, 2017 · 1 comment
Closed

IUserMessage#GetReactionUsersAsync() should take an IEmote instead of a string. #730

AntiTcb opened this issue Jun 30, 2017 · 1 comment
Assignees
@foxbot
Labels
bug project: core

Comments

@AntiTcb
Copy link
Collaborator

AntiTcb commented Jun 30, 2017

Was forgotten about during the emoji redesign.
@foxbot foxbot self-assigned this Jun 30, 2017
foxbot added a commit that referenced this issue Jun 30, 2017
@foxbot
Add GetReactionUsersAsync(IEmote) overload
f5a11d9 
Resolves #730
@foxbot foxbot mentioned this issue Jun 30, 2017
Merged
@foxbot foxbot moved this from Bugs (1.0.2) to Future: Core Features (1.x) in Library Development Jul 6, 2017
@SapiensAnatis
Copy link
Contributor

SapiensAnatis commented Jul 9, 2017 •
edited

Could this be why var ReactionDataTick = await PossiblyExistingMessage.GetReactionUsersAsync("✔️"); is producing a 10014: Unknown Emoji error for me?

edit: no, it was something stupid to do with how the tick emoji got pasted in and actually represented two characters

@foxbot foxbot moved this from Future: Core Features (1.x) to Minor Release (1.1) in Library Development Jul 10, 2017
foxbot added a commit that referenced this issue Aug 29, 2017
@foxbot
Add GetReactionUsersAsync(IEmote) overload (#731)
5d7f2fc 
* Add GetReactionUsersAsync(IEmote) overload

Resolves #730

* Remove obsolete GetReactionUsersAsync(string) overload
@foxbot foxbot removed this from Working Release (1.1) in Library Development Aug 29, 2017
FiniteReality pushed a commit to FiniteReality/Discord.Net that referenced this issue May 5, 2018
@foxbot @FiniteReality
Add GetReactionUsersAsync(IEmote) overload (discord-net#731)
41ea0d8 
* Add GetReactionUsersAsync(IEmote) overload

Resolves discord-net#730

* Remove obsolete GetReactionUsersAsync(string) overload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foxbot foxbot

Labels
bug project: core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AntiTcb @SapiensAnatis @foxbot