Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiscordShardedClient#GetShardFor(IGuild) does not handle null case #742

Closed
Joe4evr opened this issue Jul 6, 2017 · 0 comments
Closed

DiscordShardedClient#GetShardFor(IGuild) does not handle null case #742

Joe4evr opened this issue Jul 6, 2017 · 0 comments
Labels
priority: improvement project: websocket suggestion up for grabs
Projects
Library Development

Comments

@Joe4evr
Copy link
Contributor

Joe4evr commented Jul 6, 2017 •
edited

As seen here.

Can remove the private helper method recently introduced in ShardedCommandContext and make it more reliable regardless.
@foxbot foxbot closed this as completed in d5e9d6f Jan 7, 2018
FiniteReality pushed a commit to FiniteReality/Discord.Net that referenced this issue May 5, 2018
@foxbot @FiniteReality
Fix ShardedClient#GetShardFor null-case (discord-net#742)
96e0285 
This resolves discord-net#742.

Common cases for IGuild being null on access are DMs (since they do not
belong to a guild) - this change resolves null guilds to shard zero,
where DMs are also received.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: improvement project: websocket suggestion up for grabs
Projects
No open projects
Library Development
Future: Core Features (2.x)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Joe4evr @foxbot