Reconnect() after InvalidSession might be not working

[SubZero0]

After the recent discord issue, all my Discord.Net bots didn't reconnect. some screenshots:

The common between them was the "Failed to resume previous session" before disconnecting and staying like that.

Looking through the source, I saw _connection.Reconnect(); //TODO: Untested
https://github.com/RogueException/Discord.Net/blob/a384ce02abcca096cb99d55f7ba9b52c2ec48148/src/Discord.Net.WebSocket/DiscordSocketClient.cs#L421

So I thought about trying to simulate Discord sending an InvalidSession opcode with the following code:

        private async Task TryToKill()
        {
            Console.WriteLine("TRY TO KILL INITIALIZING");
            await Task.Delay(5000);
            Console.WriteLine("TRY TO KILL");
            Type type = AppDomain.CurrentDomain.GetAssemblies().First(x => x.GetName().Name == "Discord.Net.WebSocket").GetType("Discord.API.Gateway.GatewayOpCode");
            object enumValue = Enum.ToObject(type, 9);

            MethodInfo dynMethod = _client.GetType().GetMethod("ProcessMessageAsync", BindingFlags.NonPublic | BindingFlags.Instance);
            dynMethod.Invoke(_client, new object[] { enumValue, null, null, false });
            Console.WriteLine("DONE");
        }

What I did was changing the "payload" (the bool inside the Invoke). These are the results:

With false (sends an Identify):

It reconnects succesfully.

With true (calls Reconnect()):

It justs disconnects and stays like that.

I don't really know much about how the ConnectionManager works, but I'm assuming Reconnect() isn't doing it's job and leaves it in that idle disconnected state and causing what happens at #883

[Bitl]

Use this while we wait for an update:
https://gist.github.com/foxbot/7d81edab4e36497c643828638af289b8

[SubZero0]

@Bitl I know about that and I'm already doing something similar. I'm trying to find what causes it and Reconnect() might be the one (or one of them) to be blamed.

[foxbot]

This looks like the problem from my findings as well.

I have a patch running on my testing bots right now to test, just waiting on the next Discord outage to be sure.