Issue when sending a file with a text in a channel. The text is not sent. #987

FenikkusuKoneko · 2018-03-19T18:01:12Z

Hi! I'm using beta2 version. I just figured out that from v.00900 to v.00908 sending a text before sending a file is not working.

SubZero0 · 2018-03-19T18:12:43Z

Just confirming that this issue is reproducible.
Example:
Context.Channel.SendFileAsync("test/test.png", "some text");
< 900: Sends the image and the text.
>= 900: Sends only the image.

Related to #978

This resolves discord-net#987 Previous behavior was that even if `null` was passed for an embed in UploadFileAsync, the Embed property on UploadFileArgs was still specified - this meant we were always sending a payload_json. If a payload_json is specified, it seems like Discord will only read from the payload_json, and will ignore properties set outside of it. To prevent unnecessary code duplication, this commit always specifies parameters in the payload_json, and also will only include the embed if one was actually specified with real data (not null).

FenikkusuKoneko changed the title ~~Text before sending a file~~ Issue when sending a file with a text in a channel. The text is not sent. Mar 19, 2018

foxbot added the bug label Mar 19, 2018

foxbot closed this as completed in ac5ecd3 Mar 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue when sending a file with a text in a channel. The text is not sent. #987

Issue when sending a file with a text in a channel. The text is not sent. #987

FenikkusuKoneko commented Mar 19, 2018

SubZero0 commented Mar 19, 2018 •

edited

Issue when sending a file with a text in a channel. The text is not sent. #987

Issue when sending a file with a text in a channel. The text is not sent. #987

Comments

FenikkusuKoneko commented Mar 19, 2018

SubZero0 commented Mar 19, 2018 • edited

SubZero0 commented Mar 19, 2018 •

edited