Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to bot tokens based on string length #1128

Merged
merged 5 commits into from Aug 30, 2018
Merged

Add validation to bot tokens based on string length #1128

merged 5 commits into from Aug 30, 2018

Commits on Aug 20, 2018

  1. Add input validation for bot tokens based on their length

    Chris Johnston committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    5c04186 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Add token validation to BaseDiscordClient#LoginAsync 

    Adds a TokenUtils class which is used to validate that tokens are correct
    Chris Johnston committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    48623cf View commit details
    Browse the repository at this point in the history

  2. Revert changes to DiscordRestApiClient

    Chris Johnston committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    86afe76 View commit details
    Browse the repository at this point in the history

  3. Add Unit tests to the TokenUtils class, fix a logic error that was ca… 

    …ught by those tests
    Chris Johnston committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    185c55d View commit details
    Browse the repository at this point in the history

  4. Allow for API to throw exceptions 

    Moves the validation of tokens to be inside of LoginInternalAsync, and writes a Warning to the console when the supplied tokens are invalid
    Chris Johnston committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    04199b2 View commit details
    Browse the repository at this point in the history