Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed optionals having IsSpecified true when objects weren't in cache #1323

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Fixed optionals having IsSpecified true when objects weren't in cache #1323

merged 2 commits into from
Jun 6, 2019

Conversation

k-boyle
Copy link
Contributor

@k-boyle k-boyle commented Jun 6, 2019

Whilst working in the ReactionAdded and Removed events if a message/user wasn't in cache then null would be passed to the optional ctors leading to IsSpecified to be returning true

@foxbot foxbot merged commit 1cc5d73 into discord-net:dev Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxbot foxbot foxbot approved these changes

Assignees
No one assigned
Labels
priority: bug project: websocket version: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-boyle @foxbot