feature: Remove DM cache and fix references #1851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since GWv8 doesn't send channel creates for DMs anymore, I decided to stop caching them altogether.
This change should also have a positive impact on the cache size since DMs would never be removed from them while keeping a reference to the user, that would also be kept in memory forever.
Now the DMs and their authors won't be cached because of this change, the method
GetOrCreateDMAsync
was renamed toCreateDMAsync
as it won't ever be cached.A wrong method call in the client would also cause user objects to never be removed from the cache, this was also fixed.
Changes
GetOrCreateDMChannelAsync
renamed toCreateDMChannelAsync