Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing AddRef and related #1859

Merged
merged 1 commit into from
May 28, 2021

Conversation

SubZero0
Copy link
Member

Summary

GUILD_CREATE could have a few members inside it but it wouldn't add a reference and when purging the users, the RemoveRef would make the ushort _references be -1 and cause an exception.

Changes

  • AddRef for users being added by GUILD_CREATE
  • Removed GUILD_SYNC since it should be a userbot event and wouldn't fit the changes.
  • Reset DownloaderPromise after purge

@SubZero0 SubZero0 merged commit de7f9b5 into discord-net:dev May 28, 2021
@SubZero0 SubZero0 deleted the fix-missing-addref branch May 28, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant