Remove /users/@me call for socket and rework sharded client a bit #1860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current user is sent on READY and there's no need to do a rest request for it (much less N of them if using a sharded client), so this call was removed from the socket client.
In a few times some shards that werent the first one would be ready faster and
DiscordShardedClient.CurrentUser
could be null, now this property will get the first not null CurrentUser from any shard.Changes
DiscordShardedClient.Rest
might return null instead of throwing an exception if it wasnt initialized yetDiscordShardedClient.CurrentUser
will get the first not null CurrentUser from any shard instead of just the "primary"