adding scheduled events to audit log #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinchs
requested changes
Sep 2, 2022
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Show resolved
Hide resolved
src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/ScheduledEventUpdateAuditLogData.cs
Show resolved
Hide resolved
quinchs
approved these changes
Sep 2, 2022
|
@SaculRennorb please update from dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be frank, I just made this because i needed the
userandaffected_idfor ScheduledEvent updates, as the corresponding event does not provide a field of who updated the ScheduledEvent.Was sad to see that apparently noone added auditLog ids 100-102 (the ones related to ScheduledEvents) and there does not seen to be a generic way of just getting an arbitrary field from those log entries (can't even really do reflection magic because of how the data is set up).
This isn't tested very well and might also still contain some copy paste problems, as well as problems related to me not knowing the inner workings of discord.net, also I didn't bother too much with getting used to style / structures of discord.net. Feel free to reject this if you don't want to put in work, as neither do I. It seems to work, but also I just wanted to have the ids.