Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Thread user member & thread members pagination #2580

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

Misha-133
Copy link
Member

@Misha-133 Misha-133 commented Feb 2, 2023

This PR adds support for the guild member property of thread member & thread member pagination.

Changes

  • RestThreadChannel.GetUsersAsync() now wraps RestThreadChannel.GetThreadUsersAsync() to keep old code working
  • add RestThreadChannel.GetThreadUsersAsync() method which returns an IAsyncEnumerable
  • add GuildUser property to IThreadUser

@csmir
Copy link
Collaborator

csmir commented Feb 2, 2023

Discord API changes are considered exempt from our semantic versioning, since there is no way to prevent these changes from happening on Discord's end. Though, I would like some input here. Do we keep the old method, and allow it as standard for top 100 members? This way, people who upgrade won't need any refactors

@Misha-133
Copy link
Member Author

Discord API changes are considered exempt from our semantic versioning, since there is no way to prevent these changes from happening on Discord's end. Though, I would like some input here. Do we keep the old method, and allow it as standard for top 100 members? This way, people who upgrade won't need any refactors

I mostly agree with your statement
My point is that having multiple similarly named method would create some unnecessary confusion between them.

But now thinking about it - we could have the old method wrap the new one so it would keep its full functionality while also creating a new method that would allow to have more control over the process.
I think this would be a better way of implementing this functionality
I'll make necessary changes shortly.

@csmir
Copy link
Collaborator

csmir commented Feb 3, 2023

I advice marking the old method as obsolete. This way people will be notified to make changes, and future us can go and remove it completely for v4.

@csmir csmir merged commit b085621 into discord-net:dev Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants