Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Modify guild features #2605

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

Misha-133
Copy link
Member

This PR adds support for modifying guild features & adds a few missing ones.

Changes

  • add missing guild features
  • add GuildFeatures json writer
  • add GuildFeature property to GuildProperties

Copy link
Collaborator

@csmir csmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be wise to check the mutable features, to protect the developer from editing before unavailable ones get sent to discord? Maybe I read over this check, but I do not see it anywhere.

@Misha-133
Copy link
Member Author

Misha-133 commented Feb 19, 2023

Would it not be wise to check the mutable features, to protect the developer from editing before unavailable ones get sent to discord? Maybe I read over this check, but I do not see it anywhere.

Discord ignores immutable features
is this kind of validation needed in this case?

@csmir
Copy link
Collaborator

csmir commented Feb 19, 2023

Just a comment now is fine then, I will merge it

csmir
csmir previously requested changes Feb 19, 2023
src/Discord.Net.Core/Entities/Guilds/GuildProperties.cs Outdated Show resolved Hide resolved
@csmir csmir enabled auto-merge (squash) February 19, 2023 20:10
@csmir csmir merged commit 177df2c into discord-net:dev Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants