Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Media channel support #2725

Merged
merged 14 commits into from
Nov 18, 2023

Conversation

Misha-133
Copy link
Member

@Misha-133 Misha-133 commented Jul 7, 2023

docs

This PR adds support for the new media channels.

Warning

This feature is not released & fully documented yet, so use this at your own risk as things might change at any moment.

Changes

  • add IMediaChannel, rest & socket entities.
  • add new channel flag
  • add IsThumbnail property to FileAttachment - one can be set for an image used as a thumbnail in a media channel post
  • update everything to support new ChannelType
  • misc Add some missing forum channel related methods to IGuild

This PR is based on PR #2720

@Panthr75
Copy link
Contributor

Panthr75 commented Jul 9, 2023

It would be nice to have a MediaChannelProperties, so that you aren't passing ForumChannelProperties to a Create Media Channel method -- which seems wrong.

Panthr75 added a commit to Panthr75/Based-Discord.Net that referenced this pull request Jul 9, 2023
@Misha-133
Copy link
Member Author

It would be nice to have a MediaChannelProperties, so that you aren't passing ForumChannelProperties to a Create Media Channel method -- which seems wrong.

I don't see a reason to add more properties, since the media channel does not have any extra features. Also, this matches the IStageChannel reusing same VoiceChannelProperties

@Misha-133 Misha-133 marked this pull request as ready for review August 27, 2023 19:13
@Misha-133 Misha-133 requested a review from quinchs August 27, 2023 19:13
@quinchs quinchs merged commit e3cd340 into discord-net:dev Nov 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants