[Fix] Some IDiscordClient methods are not properly implemented in clients #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OverwriteGlobalApplicationCommand
Misha-133
reviewed
Sep 14, 2023
| System.Diagnostics.Debug.Assert(entity != null, "There should be at least one shard to get the entity"); | ||
|
|
||
| //Update it in case it was cached | ||
| entity.Update(model); |
There was a problem hiding this comment.
what would happen if the command is cached in multiple shard states? it would be updated in only one shard with this impl
There was a problem hiding this comment.
Updated to all shards. I wonder though if I should return the last entity (like the current implementation).
Misha-133
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some bugs related to
IDiscordClientmethods not being properly implemented inRestClient,SocketClient, andShardedSocketClientdue toBaseDiscordClient"blankly" implementing them.Changes
CreateGlobalApplicationCommandAsyncandBulkOverwriteGlobalApplicationCommandsAsynctoShardedSocketClientShardedSocketClientproperly implementsIDiscordClient.BulkOverwriteGlobalApplicationCommandandCreateGlobalApplicationCommandSocketClientproperly implementsIDiscordClient.BulkOverwriteGlobalApplicationCommandandCreateGlobalApplicationCommandRestClientproperly implementsIDiscordClient.BulkOverwriteGlobalApplicationCommandandCreateGlobalApplicationCommandRelated Issues
IDiscordClient