Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code Quality] MaxBitrate and UploadLimit in GuildHelper #2854

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[Code Quality] MaxBitrate and UploadLimit in GuildHelper #2854

merged 1 commit into from
Feb 19, 2024

Conversation

Panthr75
Copy link
Contributor

Description

Changes GuildHelper.GetUploadLimit to take a PremiumTier, and GetMaxBitrate has been added to reduce code duplication.

Changes

  • GuildHelper.GetUploadLimit takes a PremiumTier instead of IGuild
  • GuildHelper.GetMaxBitrate has been added which takes a PremiumTier
  • RestGuild.MaxBitrate now calls GuildHelper.GetMaxBitrate
  • RestGuild.UploadLimit now passes PremiumTier instead of this to GetUploadLimit
  • SocketGuild.MaxBitrate now calls GuildHelper.GetMaxBitrate
  • SocketGuild.UploadLimit now passes PremiumTier instead of this to GetUploadLimit

Misha-133
Misha-133 approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@Misha-133 Misha-133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Misha-133 Misha-133 merged commit 6256de4 into discord-net:dev Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Misha-133 Misha-133 Misha-133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Panthr75 @Misha-133