Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't depend on WebSocket for Interaction service #2912

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

quinchs
Copy link
Member

@quinchs quinchs commented Apr 15, 2024

Summary

This PR removes the pretty pointless dependency on interaction service, as we want to support full HTTP interactions without needing websockets

@quinchs quinchs requested a review from Misha-133 April 15, 2024 23:12
Copy link

github-actions bot commented Apr 15, 2024

Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
228 tests ±0  228 ✅ ±0  0 💤 ±0  0 ❌ ±0 
235 runs  ±0  235 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aa618f0. ± Comparison against base commit 13ea566.

♻️ This comment has been updated with latest results.

@quinchs quinchs enabled auto-merge (squash) April 16, 2024 03:46
@quinchs quinchs disabled auto-merge April 16, 2024 03:55
@quinchs quinchs requested a review from Liege72 April 16, 2024 03:55
@quinchs quinchs merged commit a2f624e into dev Apr 16, 2024
3 checks passed
@quinchs quinchs deleted the remove-int-dep-on-ws branch April 16, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants