Clean up command result logic #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio didn't build it properly, and showed that everything was ok. Whoops.
5 tasks
FiniteReality
changed the title
Auralytical
reviewed
May 4, 2017
| @@ -40,14 +40,13 @@ private TypeReaderResult(IReadOnlyCollection<TypeReaderValue> values, CommandErr | |||
|
|
|||
| public static TypeReaderResult FromSuccess(object value) | |||
There was a problem hiding this comment.
Is this constructor ever called?
There was a problem hiding this comment.
I don't think it is, I'll remove it
EDIT: Actually, it's used in 7 places where we don't care about the score
|
Feel free to reopen if you ever decide to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual implementation of the discussion in #632