Remove EmbedBuilder -> Embed implicit conversion #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auralytical
approved these changes
Aug 27, 2017
FiniteReality
approved these changes
Aug 27, 2017
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literally every time someone in the support channel wants to know how to modify a message's embed, they ask why the compiler tells them
Cannot implicitly convert type 'Discord.EmbedBuilder' to 'Discord.Optional<Discord.Embed>'. Reason being that the C# compiler doesn't do double implicit conversion.Therefor I believe we should force users to always
.Build()their embeds explicitly, so people can stop hitting this issue of seeming inconsistency.