System Channel Id ("Welcome new members channel") support, fix #815 #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odification (welcome message channel)
FiniteReality
approved these changes
Sep 23, 2017
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the "new member messages channel" guild option. Tried to closely follow the similar implementation of AFKChannel.
I was able to test the functionality of
SocketChannel#SystemChannelproperty andIGuild.ModifyAsync, and both appear to be working as expected.Per @khionu 's comment on #815, and some confirmation in the debugger,
system_channel_idappears to be the correct name for this value in the API. I kept this name in the implementation to stay consistent with the API.Feedback and review is appreciated. My discord handle is ChrisJ#8703.