Remove RPC from main distribution #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change removes Discord.Net.Rpc, our wrapper over Discord's RPC API, from the main library distribution. The code is still preserved in the experiments folder, but it is no longer maintained as part of the
Discord.Netsolution.Motivations
Discord's RPC API has been closed off to the public since it became documented. Any developers who might have access to it would also be equipped with Discord's official GameBridge SDK - rendering our implementation useless.
Our implementation has not been tested since July 2016, when Discord first started releasing RPC into the Canary client. Once RPC was closed off, we have not been able to test or maintain this project.
The only changes that have been made to it since then were due to changes upstream in the core interfaces, made necessary by the REST and WebSocket projects. RPC has only added dead weight and additional overhead to the development process.