Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SocketCategoryChannel properties #945

Merged
merged 5 commits into from Mar 24, 2018
Merged

Fix SocketCategoryChannel properties #945

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4efe50
Update Users property for category channels
SubZero0 Jan 30, 2018
1bbe5d5
Wrong property being used for Channels property
SubZero0 Jan 30, 2018
3817514
Resolve permissions for category
SubZero0 Feb 19, 2018
994f3d9
Remove spaces
SubZero0 Feb 19, 2018
a5b4c6f
Small fix for IChannel.GetUsersAsync
SubZero0 Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Discord.Net.WebSocket/Entities/Channels/SocketCategoryChannel.cs
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ namespace Discord.WebSocket
public class SocketCategoryChannel : SocketGuildChannel, ICategoryChannel
{
public override IReadOnlyCollection<SocketGuildUser> Users
=> Guild.Users.Where(x => x.VoiceChannel?.Id == Id).ToImmutableArray();
=> throw new NotSupportedException();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to use something like SocketTextChannels.Users, and resolve the permissions instead of throwing an exception?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, makes sense. I'll update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As talked in the dev guild, resolving the permissions could be misleading, since if the users don't have read access to any channels inside, they won't be able to see the category too.

A suggestion would be Guild.Channels.Where(x => x.CategoryId == Id).SelectMany(x => x.Users).Distinct().ToImmutableArray(); that would list all users that can see at least one channel (and the category consequently) but doesn't mean all of them can see all the channels inside it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine to me.


public IReadOnlyCollection<SocketGuildChannel> Channels
=> Guild.Channels.Where(x => x.CategoryId == CategoryId).ToImmutableArray();
Expand Down