Throw when attempting to modify a message not made by the current user #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxbot
reviewed
Mar 24, 2018
| @@ -13,6 +13,9 @@ internal static class MessageHelper | |||
| public static async Task<Model> ModifyAsync(IMessage msg, BaseDiscordClient client, Action<MessageProperties> func, | |||
| RequestOptions options) | |||
| { | |||
| if (msg.Author.Id != client.CurrentUser.Id) | |||
| throw new InvalidOperationException("Discord allows only the author of a message to change it."); | |||
There was a problem hiding this comment.
I think this would look better if it dropped the 'Discord' part and instead read Only the author of a message may change it. Passive-aggressive jabs at Discord look better in commit messages than public-facing errors :^)
foxbot
approved these changes
Mar 24, 2018
FiniteReality
pushed a commit
to FiniteReality/Discord.Net
that referenced
this pull request
May 5, 2018
discord-net#992) * Throw when attempting to modify a message not made by the current user * Didn't realize the client is passed into the MessageHelper function * Respond to feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many times people forget that they cannot change the contents of another user's message, and we are not communicating that fact properly.