added scheme checks in embed.php #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added scheme checks on the embeds
Replaced preg_match to filter_var and parse_url
|
Replaced the preg_match checks! Used filter_var to make sure its an URL. |
key2peace
previously approved these changes
Jan 12, 2023
moved url checking into a protected function checkUrl and removed the need for filter_var/parse_url
since we do proper checks on the $url before we pass it to parse_url, there is no security issue, despite codacy telling you otherwise.
key2peace
previously approved these changes
Jan 20, 2023
Exanlv
requested changes
Jan 23, 2023
Exanlv
reviewed
Jan 23, 2023
Exanlv
reviewed
Jan 23, 2023
Exanlv
previously approved these changes
Jan 23, 2023
key2peace
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1036
Added checks on the urls on the embeds