The actual pause/unpause bug fix #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that $delay was negative after unpausing because $loops wasn't getting incremented when the stream was paused. This unexpected side effect seemed to be cause the issue. My """fix""" bypassed the $loop which is why it seemed to of worked but I neglected to test on windows (woops). This fix however was tested on Windows and Linux. I also had the person who said my original """fix""" broke audio streams test and they said it works.
key2peace
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that $delay was negative after unpausing because $loops wasn't getting incremented while the stream is paused. This unexpected side effect seemed to be cause the issue. My """fix""" bypassed $loops which is why it seemed to worked but I neglected to test on windows (woops). This new fix however was tested on Windows and Linux. I also had the person who said my original """fix""" broke audio streams test it and they said it works. Note the second commit was me removing some test properties I created in my many many attempts to fix this.