Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Static method to get loop" #1121

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

key2peace
Copy link
Collaborator

Reverts #1120

@SQKo
Copy link
Member

SQKo commented May 18, 2023

As a note in future: I know the factory was deprecated, I did this intentionally long ago to fix a weird issue and compatibility with those using older dependencies and various use case of loop options/async lib and php < 8.1

As soon we have minimum 8.1, this will be no longer issue. But at the same time the options would not be actually needed anymore in future (no more $discord(['loop' => $loop]);) and another fun fact is that we would not need the $discord->run() anymore (You can try it already if you are on php 8.1+ with latest react loop lib + remove the $discord->run() from your code)

@SQKo SQKo merged commit 060ad52 into master May 18, 2023
2 checks passed
@SQKo SQKo deleted the revert-1120-valzargaming-patch-2 branch May 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants