Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: use attrs.asdict as a way to get json data of the object #1126

Merged
merged 39 commits into from Nov 23, 2022
Merged

refactor!: use attrs.asdict as a way to get json data of the object #1126

merged 39 commits into from Nov 23, 2022

Conversation

Damego
Copy link
Member

@Damego Damego commented Oct 17, 2022 •
edited by EdVraz

About

This pull request:

  1. Makes DictSerializerMixin._json as a property with using attrs.asdict to get json data of the object.
  2. Solves all troubles with editing json. You don't need to edit json anymore lol.
  3. Removes ComponentMixin and json modifing in a lot of objects like Embed.
  4. Limited using _json property in some places: using walrus operators and objects instead of dicts(wsclient).
  5. Removes outdated(since attrs added) code like here

Checklist

  • The pre-commit code linter has been run over all edited files to ensure the code is linted.
  • I've ensured the change(s) work on 3.8.6 and higher.

I've made this pull request: (check all that apply)

  • For the documentation
  • To add a new feature
  • As a general enhancement
  • As a refactor of the library/the library's code
  • To fix an existing bug
  • To resolve #ISSUENUMBER

This is:

  • A breaking change

Damego and others added 24 commits October 17, 2022 20:58
@Damego
refactor!: use attrs.asdict as a way to get json data of the object
d705496
@Damego
refactor: remove self._json mentions
ce8907c
@pre-commit-ci
ci: correct from checks.
802e42b
@Damego
refactor: wsclient is hard. part I
0e42d88
@pre-commit-ci
ci: correct from checks.
f5a736e
@Damego
Update attrs_utils.pyi
ed2b161
@Damego
refactor: remove json editing
657d729
@Damego
refactor: why
7a0135a
@Damego
refactor: add wat
b1cc157
@Damego
Merge branch 'why-didn't-we-do-this-before' of https://github.com/Dam…
d7c018a 
…ego/library into why-didn't-we-do-this-before
@Damego
refactor: limit ._json usage & remove json modifing
415ebe8
@pre-commit-ci
ci: correct from checks.
68489e7
@Damego
refactor: run pre-commit
2d1221d
@Damego
Merge branch 'why-didn't-we-do-this-before' of https://github.com/Dam…
a7552b3 
…ego/library into why-didn't-we-do-this-before
@Damego
fix: oop
15f7048
@Damego
refactor: wsclient is hard. part 2
fd30a94
@Damego
chore: remove comment
171e1ea
@pre-commit-ci
ci: correct from checks.
8ded3ed
@Damego
refactor: remove comments and debug print
b9f0e6e
@Damego
refactor(channel): remove _json modifing
a0c2328
@Damego
chore: remove comment
d6a2a9c
@Damego
refactor: wsclient is hard. Part 3. refactor __sub_command_context
138e56b
@pre-commit-ci
ci: correct from checks.
447b1a0
@Damego
chore: remove comments
7b48faf
@Damego Damego marked this pull request as ready for review October 19, 2022 08:20
@Damego
Copy link
Member Author

Damego commented Oct 19, 2022

Ready for review. Any tests appreciated

@EdVraz
Copy link
Contributor

EdVraz commented Oct 19, 2022

Do not merge for another few days as this is a major change

EdVraz
EdVraz suggested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimized code in some places: using walrus operators and objects instead of dicts(wsclient).

Out of the scope of this PR, please remove

@Damego
Copy link
Member Author

Damego commented Oct 19, 2022

Optimized code in some places: using walrus operators and objects instead of dicts(wsclient).

Out of the scope of this PR, please remove

Remove changes or just these words?

@EdVraz
Copy link
Contributor

EdVraz commented Oct 19, 2022

Optimized code in some places: using walrus operators and objects instead of dicts(wsclient).

Out of the scope of this PR, please remove

Remove changes or just these words?

The changes

@Damego Damego removed the on hold This issue/PR is on hold pending higher priority issues/PRs label Nov 6, 2022
@Damego Damego marked this pull request as ready for review November 6, 2022 17:16
EdVraz
EdVraz suggested changes Nov 6, 2022
View reviewed changes
interactions/api/gateway/client.py Show resolved Hide resolved
interactions/client/models/component.py Outdated Show resolved Hide resolved
interactions/client/models/component.py Outdated Show resolved Hide resolved
interactions/client/models/component.py Outdated Show resolved Hide resolved
interactions/client/models/component.py Outdated Show resolved Hide resolved
interactions/client/models/component.py Outdated Show resolved Hide resolved
interactions/utils/attrs_utils.py Outdated Show resolved Hide resolved
Damego and others added 10 commits November 7, 2022 08:13
@Damego @EdVraz
Update interactions/client/models/component.py
619d073 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Damego @EdVraz
Update interactions/client/models/component.py
805483c 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Damego @EdVraz
Update interactions/client/models/component.py
0245a7b 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Damego @EdVraz
Update interactions/client/models/component.py
ec13a1f 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Damego @EdVraz
Update interactions/client/models/component.py
12b27fc 
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
@Damego
Update attrs_utils.py
8cce2d2
@Damego
fix syntax error
2cea0dc
@pre-commit-ci
ci: correct from checks.
e130137
@Damego
fix: missed action rows in the modal components
87a25bc
@pre-commit-ci
ci: correct from checks.
a187eef
@EdVraz
Copy link
Contributor

EdVraz commented Nov 10, 2022

Also merge conflicts

@Damego
Copy link
Member Author

Damego commented Nov 10, 2022

Resolved

@Damego Damego requested a review from EdVraz November 10, 2022 12:38
@EdVraz EdVraz changed the title refactor: use attrs.asdict as a way to get json data of the object refactor!: use attrs.asdict as a way to get json data of the object Nov 17, 2022
@mAxYoLo01
Copy link
Contributor

Tested PR and works on my end, LGTM!

EdVraz
EdVraz approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@EdVraz EdVraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other devs don't seem interested in having a look at this PR I'm approving it

@EdVraz EdVraz merged commit a23d25e into interactions-py:unstable Nov 23, 2022
@Damego Damego deleted the why-didn't-we-do-this-before branch December 6, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdVraz EdVraz EdVraz approved these changes

@Catalyst4222 Catalyst4222 Awaiting requested review from Catalyst4222

@FayeDel FayeDel Awaiting requested review from FayeDel

@AstreaTSS AstreaTSS Awaiting requested review from AstreaTSS

@Toricane Toricane Awaiting requested review from Toricane

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Damego @EdVraz @mAxYoLo01