New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use attrs.asdict
as a way to get json data of the object
#1126
refactor!: use attrs.asdict
as a way to get json data of the object
#1126
Conversation
…ego/library into why-didn't-we-do-this-before
…ego/library into why-didn't-we-do-this-before
Ready for review. Any tests appreciated |
Do not merge for another few days as this is a major change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimized code in some places: using walrus operators and objects instead of dicts(wsclient).
Out of the scope of this PR, please remove
Remove changes or just these words? |
The changes |
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Co-authored-by: EdVraz <88881326+EdVraz@users.noreply.github.com>
Also merge conflicts |
Resolved |
attrs.asdict
as a way to get json data of the objectattrs.asdict
as a way to get json data of the object
Tested PR and works on my end, LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the other devs don't seem interested in having a look at this PR I'm approving it
About
This pull request:
DictSerializerMixin._json
as a property with usingattrs.asdict
to get json data of the object.ComponentMixin
and json modifing in a lot of objects likeEmbed
.Checklist
pre-commit
code linter has been run over all edited files to ensure the code is linted.3.8.6
and higher.I've made this pull request: (check all that apply)
This is: