Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading information with regards to mentioning users in reference #4734

Closed
439bananas opened this issue Apr 1, 2022 · 5 comments
Closed
Labels

Comments

@439bananas
Copy link

439bananas commented Apr 1, 2022

Description

When looking at the formatting reference for message, I noticed that there seemed to be a difference between mentioning users with an exclamation mark (<@!ID>) and without the exclamation mark (<@ID>), where mentioning a user without the exclamation mark seemed like it would display the username and not the guild member's nickname. This is not the case, and both give the same result, hence the description is misleading.

Steps to Reproduce

https://discord.com/developers/docs/reference#message-formatting - The table contains the misleading information

Expected Behavior

In theory, either <@ID> should show the user's username, or the description in the documentation should be adjusted.

Current Behavior

In reality, the information is, well, wrong.

Screenshots/Videos

No response

Client and System Information

Windows 11 Pro, Edge 99.0.1150.55

@439bananas 439bananas added the bug label Apr 1, 2022
@TheKing-OfTime
Copy link

Can reproduce. Any platform, any Discord branch :-)

@night
Copy link
Contributor

night commented Apr 1, 2022

After reviewing the server nicknames implementation it appears this is not a client markdown implementation, but rather a flag for the server to consume. I'm looking into if this is expected behavior, and if so we can update the documentation to properly reflect its function.

@439bananas
Copy link
Author

It appears that Android follows the behaviour of omitting the !

night added a commit that referenced this issue Apr 1, 2022
@night
Copy link
Contributor

night commented Apr 1, 2022

After speaking with our product team we've already transitioned away from using ! as a hint. The next client update will remove client support for sending !, and I've gone ahead and undocumented the syntax.

@Rapptz
Copy link
Contributor

Rapptz commented Apr 1, 2022

What about older messages that still use the older syntax or bots that explicitly use the older syntax? Wouldn't a note be better just to say that it can optionally include a ! after the @?

izxxr added a commit to izxxr/qord-legacy that referenced this issue Apr 3, 2022
DTrombett added a commit to DTrombett/ms-bot that referenced this issue Apr 3, 2022
Tais993 pushed a commit to Tais993/JDA that referenced this issue Apr 4, 2022
mrjackyliang added a commit to mrjackyliang/discord-stonker-bot that referenced this issue Nov 9, 2022
### UPDATED
- Switched project to ESM module and updated ECMA to 2022
- All permission bitfields in the configuration files are now pascal cases due to a `discord.js` upgrade
- TypeScript builds will no longer check for `config.json` inconsistencies
- Explicit `inline` properties for message embed fields
- Log messages with Discord-related properties (such as `Guild` or `TextChannel`) will now show only an object with its corresponding ID instead of the entire object itself
- Channel detection mechanism, where the bot would guess an acceptable channel based on its features instead of the channel type itself
- When posting a request to Discord via webhooks, the form data will be copied before it is sent, in case things go wrong and we can go back to reference
- When posting a request to Discord via webhooks, the entire instance will be bottlenecked to prevent 429 errors

### FIXED
- Generate output message was sent even when `log-level` was set below `30`
- Broadcast alerts skipped/continued task log message was sending an entire instance instead of the current user ID
- Return type of "toString()" on channels due to [this issue](discordjs/discord.js#7836)
- Impersonator alert failed regex rule match log message was not using cleaned nickname or username
- Server tools messages with replies will sometimes fail due to a race condition where the command message was deleted before the reply message was sent

### ADDED
- Scammer alert feature
- Threads and invites are now cached with a lifetime of 30 days
- Helper function to convert entity types and status from scheduled events

### REMOVED
- Detection for guild members with nicknames `<@!12345>` due to [this issue](discord/discord-api-docs#4734)
- Unnecessary log detail (`message.member`) for message proxy invoke function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants