Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document animated guild banners #3948

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Conversation

advaith1
Copy link
Contributor

While animating in the client is currently gated behind an experiment, uploading animated banners is not gated, which broke D++ as it wasn't expecting a_-prefixed guild banner hashes.

@Lulalaby
Copy link
Contributor

@typpo this got released recently 100% iirc.

@i0bs
Copy link
Contributor

i0bs commented Jan 1, 2022

This feature has been out for a little while now AFAIK, is the new information about the banner field in the Guild object still relevant?

@InvalidLenni InvalidLenni mentioned this pull request Feb 12, 2022
4 tasks
@@ -130,6 +130,7 @@ Guilds in Discord represent an isolated collection of users and channels, and ar

| Feature | Description |
| -------------------------------- | ------------------------------------------------------------------------------------------------------------------- |
| ANIMATED_BANNER | guild has access to set an animated guild banner image |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "image" necessary? since it can be a gif, also to be standardized with the one below (ANIMATED_ICON)

@night night merged commit 3225477 into discord:main Mar 29, 2022
@night night removed the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Mar 29, 2022
@advaith1 advaith1 deleted the animated-banners branch March 29, 2022 21:11
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants