Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP library to Community Resources List #446

Merged
merged 1 commit into from Jan 6, 2018
Merged

Add PHP library to Community Resources List #446

merged 1 commit into from Jan 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2017

(Refering to #108 (comment))

Ratelimits Handling:
All API requests get queued and pushed into endpoint-specific buckets. Each bucket gets processed sequentially, preventing any further processing after a ratelimit hit (or remaining=0). If a bucket reaches zero remaining requests or a HTTP 429 gets received, any further processing will be suspended until the reset time got reached. Hitting a global 429 will prevent any requests running after hitting to be suspended until the reset time got reached.

Source code is live at: https://github.com/CharlotteDunois/Yasmin
Most part of the ratelimiting gets done here: https://github.com/CharlotteDunois/Yasmin/blob/master/src/HTTP/APIManager.php#L237-L303
Ratelimits get parsed here: https://github.com/CharlotteDunois/Yasmin/blob/master/src/HTTP/APIManager.php#L379-L411

@ghost ghost closed this Dec 24, 2017
@ghost ghost reopened this Jan 1, 2018
@msciotti
Copy link
Contributor

msciotti commented Jan 2, 2018

We can certainly take a look at your library and we very much appreciate your contribution to our development community! It will take some time to look and review properly and decide if we want to add more libraries. Thanks for the PR, feel free to leave it open, and we will get to it!

@night night merged commit 0892b9c into discord:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants