Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app_permissions #5131

Merged
merged 3 commits into from Jun 29, 2022
Merged

Conversation

shaydewael
Copy link
Contributor

Adds changelog and updates docs for new app_permissions field


#### Jun 29, 2022

Interaction payloads now contain an `app_permissions` field whose value is the computed [permissions](#DOCS_TOPICS_PERMISSIONS/permissions-bitwise-permission-flags) for a bot or app in the context of a specific interaction (including any custom permissions for the origin channel). Similar to other permission fields, the value of `app_permissions` is a bitwise OR-ed set of permissions expressed as a string. Read details in the [interactions documentation](#DOCS_INTERACTIONS_RECEIVING_AND_RESPONDING/interaction-object).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too sad this was insta-merged. 😞 I think this would have been a better wording, and consistent with how this is named everywhere else:

Suggested change
Interaction payloads now contain an `app_permissions` field whose value is the computed [permissions](#DOCS_TOPICS_PERMISSIONS/permissions-bitwise-permission-flags) for a bot or app in the context of a specific interaction (including any custom permissions for the origin channel). Similar to other permission fields, the value of `app_permissions` is a bitwise OR-ed set of permissions expressed as a string. Read details in the [interactions documentation](#DOCS_INTERACTIONS_RECEIVING_AND_RESPONDING/interaction-object).
Interaction payloads now contain an `app_permissions` field whose value is the computed [permissions](#DOCS_TOPICS_PERMISSIONS/permissions-bitwise-permission-flags) for a bot or app in the context of a specific interaction (including channel overrides). Similar to other permission fields, the value of `app_permissions` is a bitwise OR-ed set of permissions expressed as a string. Read details in the [interactions documentation](#DOCS_INTERACTIONS_RECEIVING_AND_RESPONDING/interaction-object).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have another change coming up so I'll include this wording update. With changelogs, I'm mostly trying to get them deployed as fast as possible so I can post in DDevs, Github, etc.

@ImRodry
Copy link
Contributor

ImRodry commented Jun 29, 2022

Thanks for adding yet another feature with 0 prior warning!

@shaydewael
Copy link
Contributor Author

@ImRodry It's an additive change so it won't break any apps—it's solely giving apps more information.

We also talked about the change in the latest DDevs event.

@ImRodry
Copy link
Contributor

ImRodry commented Jun 29, 2022

@ImRodry It's an additive change so it won't break any apps—it's solely giving apps more information.

We also talked about the change in the latest DDevs event.

Usually stuff is added and only announced a few days later to allow libs to implement the feature, otherwise not many people can use it at the official launch

@DonovanDMC
Copy link
Contributor

@ImRodry It's an additive change so it won't break any apps—it's solely giving apps more information.
We also talked about the change in the latest DDevs event.

Usually stuff is added and only announced a few days later to allow libs to implement the feature, otherwise not many people can use it at the official launch

So you would rather it be announced and made usable in a few days?

@ImRodry
Copy link
Contributor

ImRodry commented Jun 29, 2022

No I'd rather it was done the opposite way: made available in the API and PR made and announced a few days later

braindigitalis added a commit to brainboxdotcc/DPP that referenced this pull request Jun 29, 2022
@nickelc
Copy link

nickelc commented Jun 29, 2022

The docs say that app_permissions? is a string but it's an integer in the payload I'm receiving.

@braindigitalis
Copy link
Contributor

If only messages had this too, we wouldnt need to cache roles at all for a lot of usages...

@shaydewael
Copy link
Contributor Author

The docs say that app_permissions? is a string but it's an integer in the payload I'm receiving.

this is a bug, and shall be fixed momentarily! sorry about that

@DonovanDMC
Copy link
Contributor

DonovanDMC commented Jun 29, 2022

No I'd rather it was done the opposite way: made available in the API and PR made and announced a few days later

Why have it available and undocumented when it can be documented as it's made available

@ImRodry
Copy link
Contributor

ImRodry commented Jun 29, 2022

If a PR is made by a team member it’s documented so libraries can implement it. Releasing like this means thousands of people will rush into support servers asking where is the support for that new feature when it most likely will take a while to come out

@advaith1
Copy link
Contributor

there is no reason for support for this feature to take a while to come out

@zeylahellyer
Copy link
Contributor

The docs say that app_permissions? is a string but it's an integer in the payload I'm receiving.

this is a bug, and shall be fixed momentarily! sorry about that

A fix for this is now out on stable. As an aside, this PR isn't the right place to discuss procedures around feature release announcements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants