Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document which messages can be deleted #5148

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Document which messages can be deleted #5148

merged 2 commits into from
Sep 14, 2022

Conversation

MinnDevelopment
Copy link
Contributor

No description provided.

arHSM
arHSM reviewed Jul 2, 2022
View reviewed changes
Copy link
Contributor

@arHSM arHSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jupith
Copy link
Contributor

Jupith commented Jul 2, 2022

Perhaps an astrix beside types;
0 6 7 8 12 18 19 20 23
With a note below that it denotes these message types are self deletable (Author is able to delete without manage messages)

seailz
seailz reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@seailz seailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

ArjunSharda
ArjunSharda reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ArjunSharda ArjunSharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@appellation appellation merged commit 54329b0 into discord:main Sep 14, 2022
@MinnDevelopment MinnDevelopment deleted the patch-message-types branch September 14, 2022 21:01
@SQKo SQKo mentioned this pull request Sep 16, 2022
Merged
@Syjalo Syjalo mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArjunSharda ArjunSharda ArjunSharda left review comments

@seailz seailz seailz left review comments

@arHSM arHSM arHSM left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MinnDevelopment @Jupith @ArjunSharda @seailz @arHSM @appellation