Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define which features are directly mutable #5270

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

Jupith
Copy link
Contributor

@Jupith Jupith commented Aug 3, 2022

No description provided.

Co-authored-by: Florian Spieß <business@minn.dev>
Copy link
Contributor

@vvito7 vvito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it supposed to actually duplicate the features above? think you could remove these ones from the Guild Features table

@advaith1
Copy link
Member

advaith1 commented Aug 3, 2022

the features table should be kept as is, would be weird to not include these there

@Jupith
Copy link
Contributor Author

Jupith commented Aug 3, 2022

is it supposed to actually duplicate the features above? think you could remove these ones from the Guild Features table

i think unless the larger list is named "non mutable features" then for the sake of completness they should remain

docs/resources/Guild.md Outdated Show resolved Hide resolved
Co-authored-by: advaith <advaithj1@gmail.com>
| INVITES_DISABLED | Manage Guild | Pauses all invites/access to the server |
| DISCOVERABLE | Administrator* | Enables discovery in the guild, making it publicly listed |

\* Server also must be passing all discovery requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\* Server also must be passing all discovery requirements
\* Server also must pass all discovery requirements

@appellation appellation merged commit aade02e into discord:main Sep 14, 2022
itohatweb added a commit to twilight-rs/twilight that referenced this pull request Sep 16, 2022
Discord only allows the `COMMUNITY`, `DISCOVERABLE` and `INVITES_DISABLED` features to be edited manually.

Reference: discord/discord-api-docs#5270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants