Fix Invalid Session opcode description #5296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently some inconsistencies between the "Opcodes and Status Codes" and "Gateway" pages. The former says that we should reconnect on OP7 before reidentifying/resuming, while the later doesn't mention this. The end of the Gateway#resuming section even says that we should only wait a random amount of time before identifying, but doesn't mention reconnecting. This inconsistency was introduced by discord#1373 (a user-made rewording/formatting cleanup of this page). On our bot, we are always reidentifying/resuming over the existing gateway connection without any issue. I've also looked at Eris, which also reidentify over the existing connection. Therefore I believe that reconnecting is, in fact, not necessary. The wording I'm removing has likely been added by error.
|
Closing this PR because this info is now accurate with the upcoming change with the resume_gateway_url: #5282 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed during a conversation on the Discord API server, there is currently an inconsistency between the "Opcodes and Status Codes" and "Gateway" pages.
The former says that we should reconnect on OP9 before reidentifying/resuming, while the later doesn't mention this.
The end of the Gateway#resuming section even says that we should only wait a random amount of time before identifying, and doesn't mention reconnecting.
This inconsistency was introduced by #1373 (a user-made rewording/formatting cleanup of this page).
On our bot, we are always reidentifying/resuming over the existing gateway connection without any issue.
I've also looked at Eris, which also reidentify over the existing connection.
Therefore I believe that reconnecting is actually not necessary. The wording I'm removing has likely been added by error in the aforementioned PR.