Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document role subscriptions #5724

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Dec 8, 2022

Bots can't access the subscription-related endpoints but I documented the role tags, premium emoji stuff, integration type, message type, and publicly available guild features (not the testing guild features). I didn't document the subscription listing stuff in /discovery/:slug since that endpoint is not documented yet (requires #1762).

resolves #5711

Copy link
Contributor

@IllagerCaptain IllagerCaptain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning
Nerd 🤓

But more seriously, I really like the wording and formatting you used, it's in a way an idiot could understand. Really thorough too.

Copy link
Contributor

@johnnyataisg johnnyataisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just left one comment, let's make a quick change for that and get this merged

| INVITES_DISABLED | guild has paused invites, preventing new users from joining |
| INVITE_SPLASH | guild has access to set an invite splash background |
| MEMBER_VERIFICATION_GATE_ENABLED | guild has enabled [Membership Screening](#DOCS_RESOURCES_GUILD/membership-screening-object) |
| MONETIZATION_ENABLED | guild has enabled monetization |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove MONETIZATION_ENABLED since it's been replaced

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done; are there any other features I should add?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it all looks good. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll get this merged soon

@shaydewael shaydewael merged commit e003051 into discord:main Jan 4, 2023
@advaith1 advaith1 deleted the role-subscriptions branch January 4, 2023 05:46
KubaZ2 added a commit to NetCordDev/NetCord that referenced this pull request Jan 9, 2023
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Jan 18, 2023
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Jan 18, 2023
lukellmann added a commit to lukellmann/kord that referenced this pull request Mar 4, 2023
* rename GuildFeature.CreatorMonetizableProvision to
  GuildFeature.CreatorMonetizableProvisional

* deprecate GuildFeature.MonetizationEnabled, see
  discord/discord-api-docs#5724 (comment)

* add @SerialName for DiscordRoleTags.botId

* add RoleTags.isLinkedRole

* fix DiscordMessage.roleSubscriptionData nullability

* fix KDocs

see discord/discord-api-docs#5724 and
discord/discord-api-docs#5828
lukellmann added a commit to kordlib/kord that referenced this pull request Mar 5, 2023
* rename GuildFeature.CreatorMonetizableProvision to
  GuildFeature.CreatorMonetizableProvisional

* deprecate GuildFeature.MonetizationEnabled, see
  discord/discord-api-docs#5724 (comment)

* add @SerialName for DiscordRoleTags.botId

* add RoleTags.isLinkedRole

* fix DiscordMessage.roleSubscriptionData nullability

* fix KDocs

see discord/discord-api-docs#5724 and
discord/discord-api-docs#5828

Co-authored-by: NoComment <67918617+NoComment1105@users.noreply.github.com>
shaydewael pushed a commit to Jupith/discord-api-docs that referenced this pull request May 14, 2024
* Document role subscriptions

* remove MONETIZATION_ENABLED guild feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscrption Message Type Not Documented
4 participants