Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go support #31

Closed
wants to merge 17 commits into from
Closed

Add Go support #31

wants to merge 17 commits into from

Conversation

IAmJSD
Copy link

@IAmJSD IAmJSD commented Jun 20, 2020

Fixes #29

@IAmJSD IAmJSD marked this pull request as ready for review June 20, 2020 20:39
@zorkian
Copy link
Member

zorkian commented Jun 24, 2020

Hey Jake --

So first, thanks for writing this. Always happy to see people contributing back upstream.

Discord is actually moving away from Go internally, and we're down to the last handful of services, none of which need erlpack support. I want to make sure that anything Discord hosts on our repositories is actually maintained, reviewed, documented, etc etc, and unfortunately we aren't able to do that with Go at this time.

As a different solution, how would you feel about creating your own erlpack-go repository? I'm happy to update the README here and tell people where to find your repository if they need a Go library so they know where to find it. Would that work for you?

@jamiebuilds jamiebuilds mentioned this pull request Jun 24, 2020
@IAmJSD
Copy link
Author

IAmJSD commented Jun 24, 2020

Hi @zorkian,

That's completely understandable! I created https://github.com/JakeMakesStuff/go-erlpack last night so that I could work on erlpack integration, so that's the repository which I will maintain from now. 👍

@zorkian
Copy link
Member

zorkian commented Jun 24, 2020

Thank you! I've updated our README to point to you repository :)

Going to close this PR now. Best of luck! (And of course, if you find any issues in the Python/C++/JS, we're happy to review & take those fixes!)

@zorkian zorkian closed this Jun 24, 2020
@IAmJSD IAmJSD deleted the feature/golang branch June 25, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go support
2 participants