-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Compatibility for Node 16 #41
Conversation
Ah, my bad. I didn't see #40, should I close this PR? |
I'll just merge with mines if I can |
Okay |
Reopening this PR because #40 is closed |
I forgot to delete |
Can you delete the package lock? |
Hi sorry, for the late response, I just deleted the lockfile @jhgg |
While you are at it, merging #42 would be useful too :) |
@adill - when you get a chance, can you double check that this looks sensible? |
Edited the first message for an explanation. Note that this has not been tested in Mac OS, but it works on Node.js v8 to v16 on Arch Linux, Node.js v8 to v16 on Windows (build 19044.1165, msvs 2019), and Node.js v14-v16 on Alpine Linux (docker) |
Yea, eta would be good. Other pr is fucked. |
any progress? |
Hi, sorry for the bump, any progress on PR Review? Just a friendly reminder that Node 16 will be an Active LTS next month. |
Still no ETA until hzmi's fork merged, use hzmifork or don't add this [discord/erlpack#41](discord/erlpack#41) Co-authored-by: Zen <45705890+KurokuTetsuya@users.noreply.github.com>
Sorry again, but bump |
Got final signoff from Jake and Andy. Thanks for this! |
Nodejs 16 uses V8 engine version 9.0, that requires c++14 features, so we need to remove "-std=c++11" from binding.gyp.
Idk why "-std=c++11" is added in f3c64a0
REFS:
nodejs/node-gyp#2387 (comment)
nodejs/node#38367