Release/v1.1.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Encode a common pattern as the default behavior. It is a common pattern when using GenRegistry to wrap lookup_or_start/4 with a call to lookup/2 first. This pattern exists because it allows the caller to do a fast ETS lookup in the client context without having to switch to the server context when the process is already running. lookup_or_start/4 accepts a GenServer.server(), in the cases that a caller uses a pid, the old path will be followed since there's no good way to go from pid to :ets.tab(). If the caller provides an atom (local named process) then the atom will be assumed to be the :ets.tab() and a client-side lookup performed. * Tests for the non-name case
birarda
approved these changes
Jul 16, 2021
| {:error, :not_found} -> | ||
| @gen_module.call(registry, {:lookup_or_start, id, args}, timeout) | ||
| end | ||
| end |
Co-authored-by: Stephen Birarda <commit@birarda.com>
Co-authored-by: Stephen Birarda <commit@birarda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new features
nameargument.