Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module-ify lilliput #75

Merged
merged 3 commits into from Aug 15, 2020
Merged

Module-ify lilliput #75

merged 3 commits into from Aug 15, 2020

Conversation

iredelmeier
Copy link
Contributor

Fixes #55

@iredelmeier
Make a go module
8c7bb09
@iredelmeier
Replace dep symlinks with copies of the target
e568291 
Go modules don't handle symlinks well due to
golang/go#39417.

This hacky fix works around the issue by replacing symlinks with regular
files.
@iredelmeier
Change back to symlinks
c2c7325 
This let's us confirm the pipeline is doing the right thing.
@iredelmeier iredelmeier merged commit 59cd2e5 into discord:master Aug 15, 2020
@iredelmeier iredelmeier deleted the module branch August 15, 2020 20:06
@jameshartig
Copy link

jameshartig commented Aug 19, 2020 •
edited

@iredelmeier @brian-armstrong-discord it looks like the github organization is now discord, should we continue using discord or discordapp?

@iredelmeier
Copy link
Contributor Author

Good question! We stuck with discordapp for now so we can have a smoother transition for everyone already importing that way, based on a hypothesis that the majority are doing so. Longer term, we'd probably like to to move it to discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-armstrong-discord brian-armstrong-discord brian-armstrong-discord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failed: lilliput don't work with go mod
3 participants
@iredelmeier @jameshartig @brian-armstrong-discord