Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting messages doesn't require the client's permissions to be superior to the author of the message #4

Closed
metagn opened this issue Feb 2, 2016 · 0 comments

Comments

@metagn
Copy link
Contributor

metagn commented Feb 2, 2016

If the title wasn't clear enough, DiscordUtils' checkPermissions method seems to check the client's permissions be equal to the permissions given. Thing is, deleting messages doesn't require this and only the client to have sufficient permissions to delete the message. Therefore, that method wouldn't exactly work.

P.S.: You seem to also check for mentioning everyone and embedding permissions, even though the client should still be able to send that message with everyone and embedding and without permissions.

d-g-n pushed a commit that referenced this issue Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants