This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Migration to JSON::Serializable #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasintel
reviewed
Jun 14, 2020
src/discordcr/mappings/oauth2.cr
Outdated
Comment on lines
36
to
40
| include JSON::Serializable | ||
| property icon : String? | ||
| property id : Snowflake | ||
| property members : Array(TeamMember) | ||
| property owner_user_id : Snowflake |
There was a problem hiding this comment.
it looks like the identation is a bit off here
src/discordcr/mappings/oauth2.cr
Outdated
Comment on lines
44
to
48
| include JSON::Serializable | ||
| property membership_state : TeamMembershipState | ||
| property permissions : Array(String) | ||
| property team_id : Snowflake | ||
| property user : User |
There was a problem hiding this comment.
it looks like the identation is a bit off here
src/discordcr/mappings/vws.cr
Outdated
Comment on lines
6
to
8
| struct IdentifyPacket | ||
| include JSON::Serializable | ||
| def initialize(server_id, user_id, session_id, token) |
There was a problem hiding this comment.
i think its a good practice to separate the include JSON::Serializable with one newline
e.g.
class Klass
include JSON::Serializable
property username : String?
end
|
No problem! I'm glad I could help 😄 |
|
@MineBartekSA You should able to run |
|
Oh, right, I totally forgot that this tool exists. Thanks for the tip |
|
Done, but still needed to add some new lines by hand |
lucasintel
approved these changes
Jun 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've migrated all structs to the new JSON::Serializable in Crystal 0.35.0