Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limit Manager #5

Closed
Skillz4Killz opened this issue Feb 9, 2020 · 1 comment
Closed

Rate Limit Manager #5

Skillz4Killz opened this issue Feb 9, 2020 · 1 comment
Projects

Comments

@Skillz4Killz
Copy link
Contributor

We need to implement a nice and clean easy to reuse rate limit manager. The goal will be to try and see if this rate limit manager can support across all shards and not just on 1 shard.

I believe the rate limit manager should exist on the Shard Manager itself and not on a shard or a client. The shard manager will contain all the shards and therefore the rate limiter can be set a bit better.

Thoughts? Alternatives?

@Skillz4Killz Skillz4Killz added this to To do in 1.0 Mar 2, 2020
@Skillz4Killz
Copy link
Contributor Author

Should be done now. Only thing left is to handle sharding and try to get all shards to use this rate limit manager

1.0 automation moved this from To do to Done Mar 19, 2020
Skillz4Killz pushed a commit that referenced this issue Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.0
  
Done
Development

No branches or pull requests

1 participant