Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add cli #3037

Merged
merged 5 commits into from Oct 15, 2023
Merged

feat(cli): add cli #3037

merged 5 commits into from Oct 15, 2023

Conversation

H01001000
Copy link
Contributor

@H01001000 H01001000 commented May 21, 2023

This PR add a cli to discordeno, just a help command and generate command

@H01001000 H01001000 self-assigned this May 21, 2023
@github-actions github-actions bot added pkg-all Affects every package pkg-bot Affects the bot package t-feat A new feature labels May 21, 2023
@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (730ad9a) 78.65% compared to head (2f95a2a) 78.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3037      +/-   ##
==========================================
- Coverage   78.65%   78.01%   -0.64%     
==========================================
  Files         185      186       +1     
  Lines       22076    22086      +10     
  Branches      469      448      -21     
==========================================
- Hits        17364    17231     -133     
- Misses       4701     4849     +148     
+ Partials       11        6       -5     
Flag Coverage Δ *Carryforward flag
bot 56.85% <ø> (-1.21%) ⬇️
bot-e2e 55.37% <ø> (-2.62%) ⬇️ Carriedforward from 6bc3674
bot-unit 49.48% <ø> (ø)
discordeno 8.33% <0.00%> (-91.67%) ⬇️
discordeno-unit 8.33% <0.00%> (-91.67%) ⬇️
gateway 73.58% <ø> (ø)
gateway-integration 73.58% <ø> (ø)
gateway-unit 29.71% <ø> (ø)
rest 83.59% <ø> (-0.69%) ⬇️
rest-e2e 29.35% <ø> (+1.32%) ⬆️ Carriedforward from 6bc3674
rest-unit 71.03% <ø> (ø)
types 100.00% <ø> (ø)
types-unit 100.00% <ø> (ø)
utils 90.04% <ø> (ø)
utils-unit 90.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/discordeno/src/bin/index.ts 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented May 21, 2023

Benchmark

Detail results of benchmarks
Benchmark suite Base (730ad9a) Latest Head (2f95a2a) 6bc3674 2c6d199 b0e97ca 8d63858 9d2e5cd
[transformer] message cache check RSS 114.55 MB ±1% 117.44 MB ±1% 120.22 MB ±1% 113.32 MB ±1% 117.31 MB ±1% 113.61 MB ±1% 121.14 MB ±1%
[transformer] message cache check Heap Used 117.3 MB ±1% 118.41 MB ±1% 116.71 MB ±1% 120.14 MB ±1% 117.83 MB ±1% 116.96 MB ±1% 117.03 MB ±1%
[transformer] message cache check Heap Total 107.41 MB ±1% 106.88 MB ±1% 107.67 MB ±1% 104.52 MB ±1% 107.14 MB ±1% 107.41 MB ±1% 107.14 MB ±1%
[transformer] old message cache check RSS 84.14 MB ±1% 82.86 MB ±1% 77.55 MB ±1% 77.56 MB ±1% 80.95 MB ±1% 79.78 MB ±1% 85.58 MB ±1%
[transformer] old message cache check Heap Used 101.47 MB ±1% 102.95 MB ±1% 103.36 MB ±1% 102.51 MB ±1% 101.21 MB ±1% 101.61 MB ±1% 101.71 MB ±1%
[transformer] old message cache check Heap Total 81.98 MB ±1% 78.31 MB ±1% 76.21 MB ±1% 80.93 MB ±1% 81.45 MB ±1% 75.42 MB ±1% 81.98 MB ±1%
[Cache Plugin] RSS 0.66 MB ±2.98% 0.57 MB ±2.98% 0.66 MB ±2.98% 0.57 MB ±2.98% 0.57 MB ±2.98% 0.66 MB ±2.98% 0.66 MB ±2.98%
[Cache Plugin] Heap Used 10.7 MB ±1.44% 10.82 MB ±1.43% 10.74 MB ±1.44% 10.69 MB ±1.44% 10.68 MB ±1.44% 10.75 MB ±1.43% 10.83 MB ±1.43%
[Cache Plugin] Heap Total 0 MB ±0% 0 MB ±0% 0 MB ±0% 0 MB ±0% 0 MB ±0% 0 MB ±0% 0 MB ±0%
rest.simplifyUrl 212243 ops/sec ±0.25% 214869 ops/sec ±0.78% 217364 ops/sec ±0.20% 207966 ops/sec ±2.70% 209579 ops/sec ±0.36% 215028 ops/sec ±0.37% 209630 ops/sec ±0.45%
Camelize 1 event 6092 ops/sec ±0.27% 6143 ops/sec ±0.24% 6177 ops/sec ±0.23% 5855 ops/sec ±0.63% 6060 ops/sec ±0.28% 6025 ops/sec ±0.27% 6035 ops/sec ±0.33%
Snakelize 1 event 6100 ops/sec ±0.27% 6012 ops/sec ±0.36% 6136 ops/sec ±0.24% 5814 ops/sec ±0.31% 5996 ops/sec ±0.26% 6022 ops/sec ±0.20% 6081 ops/sec ±0.25%

@Skillz4Killz
Copy link
Contributor

Skillz4Killz commented May 23, 2023

Should this not be its own package?

Imagine when discord finalizes the OAPI spec and we use that to automatically generate typings like

npx prisma generate but instead of npx discordeno generate

@github-actions github-actions bot removed the pkg-bot Affects the bot package label Oct 9, 2023
@H01001000 H01001000 changed the title feat(bot): add cli feat(cli): add cli Oct 11, 2023
@H01001000 H01001000 marked this pull request as ready for review October 11, 2023 23:01
@H01001000 H01001000 added this pull request to the merge queue Oct 15, 2023
Merged via the queue into main with commit 6a55a6f Oct 15, 2023
37 checks passed
@H01001000 H01001000 deleted the H01001000/feat/cli branch October 15, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg-all Affects every package t-feat A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants