This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
refactor: cleanup extended interface #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almeidx
reviewed
Oct 28, 2021
| /** | ||
| * A Map with additional utility methods. This is used throughout discord.js rather than Arrays for anything that has | ||
| * an ID, for significantly improved performance and ease-of-use. | ||
| * @extends {Map} | ||
| * @property {number} size - The amount of elements in this collection. | ||
| */ | ||
| /* eslint-disable-next-line no-redeclare */ |
There was a problem hiding this comment.
Disable this rule and use the typescript-eslint equivalent instead (or don't)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Removes the overrides for the map methods that just directly called super.x in favor of more verbose jsdoc (which appears to be the only reason for these overrides).
Also separates the constructor into the typescript only interface so that there isn't a useless constructor that overwrites itself when
useDefineForClassFieldsis set trueStatus and versioning classification: